Deltakit/deltakit

request: enforce additional typing rules

Open

#29 aperta il 18 set 2025

Vedi su GitHub
 (1 commento) (0 reazioni) (0 assegnatari)Python (30 fork)auto 404
good first issue

Metriche repository

Star
 (60 star)
Metriche merge PR
 (Metriche PR in attesa)

Descrizione

Motivation

mypy is performing some checks, but there are many failures that are currently not checked for or ignored. We need to work to eliminate these waivers over time.

All improvements welcome. To find current exclusions/ignores, see mypy.ini and search code for # type: ignore / # pylint: disable.

Proposed solution

This looked like a good article about typing priorities, so with that in mind, these seem like the most important errors to fix:

  • disallow_untyped_defs
  • disallow _any_unimported
  • check_untyped_defs
  • warn_return_any
  • warn_unused_ignores
  • deltakit_circuit disable_error_code
  • deltakit_decodedisable_error_code
  • deltakit_explorer disable_error_code

Lower priority:

  • disallow_incomplete_defs
  • implicit_reexport
  • warn_unreachable
  • disallow_any_explicit
  • disallow_any_expr
  • disallow_any_decorated
  • enforce typing in tests

Guida contributor