DaymareOn/hdtSMP64

Remove hardcoded exterior world space ID list from WeatherManager

Open

#239 aperta il 26 mar 2026

Vedi su GitHub
 (0 commenti) (0 reazioni) (0 assegnatari)C++ (34 fork)github user discovery
enhancementhelp wantedrefactor

Metriche repository

Star
 (67 star)
Metriche merge PR
 (Merge medio 15h 45m) (28 PR mergiate in 30 g)

Descrizione

Summary

The NOT_EXTERIOR_WORLDS array in src/WeatherManager.h (used in WeatherManager::runWeatherTickImpl) contains a static, hardcoded list of Skyrim world space Form IDs that should be treated as non-exterior (i.e., no wind). This approach is fragile and difficult to maintain as it:

  • Requires recompiling the DLL to add/remove world spaces.
  • Does not account for modded world spaces that might also be interiors.
  • Was originally added in commit 34743ff.

Goal

Remove the hardcoded list by doing one or both of the following:

  1. Find a programmatic method — e.g., checking whether the world space has a valid sky/climate attached (similar to how the Creation Kit detects outdoor environments), or inspecting flags on the TESWorldSpace record. The RE server may have insight here.
  2. Move to a data/config file — allow users/maintainers to configure the excluded world space IDs externally (e.g., in the existing SMP config file) rather than baking them into the DLL.

References

Guida contributor