BeeStation/NSV13

*fingergun emote issue

Open

Aperta il 21 giu 2021

Vedi su GitHub
 (1 commento) (0 reazioni) (0 assegnatari)DM (124 star) (267 fork)batch import
BugGood first issueHacktoberfestNeeds Reproduction StepsStaleUpstream Issue

Descrizione

Round ID: 2625

Testmerges:

https://github.com/BeeStation/NSV13/pull/1422

Reproduction:

I was playing around with the *fingergun emote a lot and I was switching between Ruben and Joaquin often with the manual aim. After that, Ruben walked away and I wasn't locking onto him anymore, but it still told me when he dropped something and took something out.

Guida contributor

Tech stack
Nessuno
Dominio
Nessuno
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
mostly clear
Prerequisiti
Familiarity with DM languageUnderstanding of SS13 emote system
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
20
Direzione di ricerca
Investigate the *fingergun emote code in the repository, possibly in emote related files. Check the testmerge PR #1422 for changes that might have introduced this bug. Reproduce the steps: switch between users with manual aim and observe the lingering tracking after target walks away. Identify where the emote tracking state is cleared and ensure it resets properly when the target is no longer locked.