B-Lang-org/bsc

Suggest missing 'valueOf' in error message

Aperta

#276 aperta il 8 nov 2020

 (0 commenti) (0 reazioni) (0 assegnatari)Haskell (178 fork)batch import
error-messagesgood first issue

Metriche repository

Star
 (1108 stelle)
Metriche merge PR
 (Merge medio 17g 1h) (18 PR mergiate in 30 g)

Descrizione

If valueOf is left out of this code:

typedef 32 DataWidth;

function Bit#(DataWidth) fn (Bit#(DataWidth) x);
  //if (valueOf(DataWidth) == 64)
  if (DataWidth == 64)
    return 8;
  else
    return 4;
endfunction

then BSC, noticing that the name DataWidth is capital, looks for a constructor by that name and doesn't find one, so it reports an error about an unbound constructor name:

Error: "Test.bsv", line 5, column 7: (T0003)
  Unbound constructor `DataWidth'

It should be easy for BSC, in this case, to look for the name in the type domain and, if it's found, add a message that this name is a type and maybe a pseudo-function like valueOf is missing.

Guida contributor