ArduPilot/ardupilot

handle_mission_write_partial_list is too strict

Aperta

#4889 aperta il 25 set 2016

 (3 commenti) (0 reazioni) (0 assegnatari)C++ (15.603 fork)batch import
AllVehiclesLibraryMAVLinkgood first issue

Metriche repository

Star
 (9336 stelle)
Metriche merge PR
 (Merge medio 26g 16h) (166 PR mergiate in 30 g)

Descrizione

Issue details

Currently GCSCommon.cpp@handle_mission_write_partial_list checks if the partial waypoint list is inside the current mission count boundary unnecessarily. This limits the utility of partial waypoint writing modifications because we can never expand the mission count.

A very simple case is appending a waypoint to a waypoint list. As far as I know a full rewrite of the mission plan would be required because the only other way to change the waypoint list is sending a mavlink_msg_mission_count* message with the previous mission count plus one. This is exactly what a partial list is for.

Removing the upper bound checks would not result in a problem because GCS_Common.cpp@GCS_MAVLINK::handle_mission_item:839 already handles the case where the mission seq is bigger than mission.num_commands().

Am I wrong in these assumptions? If theoretically there is no problem I can produce a patch removing the upper bound checks.

Guida contributor