istio/istio.io

Fix events.istio.io

Open

#14,665 opened on Feb 29, 2024

View on GitHub
 (1 comment) (0 reactions) (0 assignees)HTML (740 stars) (1,492 forks)batch import
good first issue

Description

https://github.com/istio/istio-events is the source repo for the events.istio.io website. A few things are broken about the way the 2021 and 2022 sites are archived:

Relative paths

Some URLs are rooted at /, where the actual site is now hosted at /istiocon-2021/. Please fix all URLs to be rooted at / and then use the Hugo baseURL variable and canonifyURLs. You will also need to change hard-coded appearances of / in inline styles to refer to {{ .Site.BaseURL }}.

Here's a page which shows you the error.

Lightbox plugin

The lightbox plugin that the vendor used is not compatible with CNCF licensing. When the above is fixed, you will hopefully be able to see what actually uses the lightbox plugin; it can be replaced with another such plugin that is MIT or Apache licensed.

Contributor guide

Tech stack
javascripthtmlcss
Domain
documentation
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Hugo templatingHTMLCSSjQuery
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue requires fixing relative paths in Hugo templates by using the baseURL variable and canonifyURLs. The speakers page at https://events.istio.io/istiocon 2022/speakers/ shows broken links due to hardcoded '/' paths. Also, the lightbox plugin at 2021/themes/istiocon/static/plugins/jquery/jquery.fancybox.js must be replaced with an MIT or Apache licensed alternative. Review the theme's template files for hardcoded paths and the usage of the lightbox plugin to determine replacement.
Fix events.istio.io · istio/istio.io#14665 | Good First Issue