istanbuljs/nyc

nyc check-coverage: new command flag

Open

#432 opened on Nov 1, 2016

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (5,468 stars) (392 forks)batch import
Great First Contributionenhancementhelp wanted

Description

Hello! Just want to suggest new CLI flag for the check-coverage command executes it like all other flags are set to 100.

npm check-coverage --max

instead

nyc check-coverage --lines 100 --branches 100 --statements 100 --functions 100

It looks visually better and shorter in the package.json.

Also why not to be more configurable like --max 90 to sets everything to 100, but branches to 90.

Better flag name?

Contributor guide

Tech stack
javascriptnodejs
Domain
cli
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic understanding of CLI toolsFamiliarity with nyc
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Explore the nyc codebase, particularly the CLI argument parsing in `bin/nyc.js` and the check coverage implementation in `lib/commands/check coverage.js`. Implement a new ` max` flag that sets all coverage thresholds (lines, branches, statements, functions) to 100 or to a specified value, with ` max 90` overriding just branches. The current thresholds are parsed from CLI flags; this new flag should set defaults before applying any explicit flags. Review the existing test suite for check coverage to ensure proper test coverage.