Error in ViewControl::ConvertFromPinholeCameraParameters in ViewControl.cpp

Start in ViewControl.cpp at ViewControl::ConvertFromPinholeCameraParameters and inspect the conditional shown in the issue. Reproduce the camera-parameter conversion case and verify that the condition evaluates the principal-point comparison correctly, with the existing warning and return behavior preserved when dimensions do not match.

Checklist

• I have searched for similar issues.
• For Python issues, I have tested with the latest development wheel.
• I have checked the release documentation and the latest documentation (for main branch).

Describe the issue

I found that, in the code "ViewControl.cpp", there is an error in bool ViewControl::ConvertFromPinholeCameraParameters.
The conditional statement mistakenly uses = instead of -：
‘’‘
if (!allow_arbitrary &&
(window_height_ <= 0 || window_width_ <= 0 ||
window_height_ != intrinsic.height_ ||
window_width_ != intrinsic.width_ ||
std::abs(intrinsic.intrinsic_matrix_(0, 2) -
((double)window_width_ / 2.0 - 0.5)) > threshold ||
std::abs(intrinsic.intrinsic_matrix_(1, 2) =
((double)window_height_ / 2.0 - 0.5)) > threshold)) {
utility::LogWarning(
"[ViewControl] ConvertFromPinholeCameraParameters() failed "
"because window height and width do not match.");
return false;
}
’‘’

Steps to reproduce the bug

if (!allow_arbitrary &&
        (window_height_ <= 0 || window_width_ <= 0 ||
         window_height_ != intrinsic.height_ ||
         window_width_ != intrinsic.width_ ||
         std::abs(intrinsic.intrinsic_matrix_(0, 2) -
                  ((double)window_width_ / 2.0 - 0.5)) > threshold ||
         std::abs(intrinsic.intrinsic_matrix_(1, 2) =
                          ((double)window_height_ / 2.0 - 0.5)) > threshold)) {
        utility::LogWarning(
                "[ViewControl] ConvertFromPinholeCameraParameters() failed "
                "because window height and width do not match.");
        return false;
    }

Error message

The conditional statement mistakenly uses = instead of -：

Expected behavior

No response

Open3D, Python and System information

Open3D = 0.18.0

Additional information

No response