ipfs/kubo

secp256k1 key support is missing pem-pkcs8-cleartext import/export

Open

#9,912 opened on May 31, 2023

View on GitHub
 (6 comments) (1 reaction) (0 assignees)Go (13,906 stars) (2,725 forks)batch import
P2good first issuehelp wantedkind/bug

Description

Seems https://github.com/ipfs/kubo/pull/9830 was missing a test for --format :)

cc @Jorropo @imthe1

Installation method

built from source

Version

0.20.0-dev

Description

$ ipfs key gen --type=secp256k1 key_secp256k1
$ ipfs key export key_secp256k1 -f pem-pkcs8-cleartext --output key.pem
Error: marshalling key to PKCS8 format: x509: unknown key type while marshaling PKCS#8: *crypto.Secp256k1PrivateKey

Contributor guide

Tech stack
go
Domain
securitycli
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go programmingcryptography basicsPKCS8 format
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the marshalling code for PKCS8 in the ipfs/kubo repository, specifically the function that returns 'x509: unknown key type'. The PR #9830 introduced pem pkcs8 cleartext format but did not include support for secp256k1 keys. Look at how other key types are handled and implement the missing case for *crypto.Secp256k1PrivateKey.