ipfs/kubo

MFS remote pinning policy: log ERROR if pin failed

Open

#7,917 opened on Feb 16, 2021

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Go (2,725 forks)batch import
P2effort/hoursexp/intermediategood first issuehelp wantedkind/enhancementstatus/readytopic/pinning

Repository metrics

Stars
 (13,906 stars)
PR merge metrics
 (Avg merge 4d 2h) (28 merged PRs in 30d)

Description

go-ipfs 0.8.0-rc2 dispatches remote pin request but does not act on its status, so without manual inspection it is possible to miss the fact that MFS pinning (Pinning.RemoteServices.*.Policies.MFS, #7913) stopped working.

I believe we should keep checking pin status every RepinInterval until its pinned or failed, and if it's the latter, print ERROR into remotepinning/mfs logger. Pinning may fail for multiple reasons, main ones is some arbitrary timeout to find a provider for the data, another one is when you try to pin DAG bigger than allowed quota.

By printing error on MFS pin failure, node operator will be able to notice that remote pinning stopped working due to one of mentioned reasons.

cc #7559 @aschmahmann does this sound sensible?

Contributor guide

Research direction
Locate the remote pinning dispatch code and add error logging when pin status is 'failed'.
Tech stack
go
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75