ipfs/kubo

Can pinning get a verbose argument?

Open

#6042 opened on Mar 3, 2019

View on GitHub
 (11 comments) (0 reactions) (0 assignees)Go (13,906 stars) (2,725 forks)batch import
help wantedneed/analysis

Description

Hi,

I'm currently executing ipfs pin add -r <QmHash>. It's been running for hours and i have absolutely no clue if anything is happening at all!

I'm missing a "verbose" flag. I'm sure IPFS is doing all kinds of stuff right now that would be visible if i raised the logging level, but that might be too much information. I'd like to see logs targeted at the current pin action to have some clue of what's happening. Obviously only if i provide the hypothetical -v or --verbose flag.

Cheers, Mark

Contributor guide

Tech stack
go
Domain
clideveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Start by examining the pin add command implementation in the core/commands/pin.go file. Look for existing flag patterns, such as how the recursive flag is defined. Then add a new boolean flag ` verbose` using the `cmd` package's `Bool` or `StringBool` function. Update the command logic to output progress messages when the flag is set. Check the issue comments for any additional user expectations or maintainer feedback. Finally, ensure the tests in core/commands/pin test.go are updated accordingly.