ipfs/kubo

Escape paths in `ipfs ls`

Open

#5,887 opened on Jan 2, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Go (2,725 forks)batch import
help wanted

Repository metrics

Stars
 (13,906 stars)
PR merge metrics
 (Avg merge 4d 2h) (28 merged PRs in 30d)

Description

Running ipfs object patch add-link QmUNLLsPACCz1vLxQVkXqqLX5R1X345qqfHbsf67hvA3Nn $(echo -e '\e[1;1H\e[44;37m\e[K\e[2;1HHI\e[34m_\e[37mTHERE!\e[3;1H\e[K\e[49;39m') QmUNLLsPACCz1vLxQVkXqqLX5R1X345qqfHbsf67hvA3Nn gets us a really fun hash - QmUKpty1aF3ak42WTnebPsGkYyq6A6g9Jt2fYpanwzk6tx.

ipfs ls on that hash will print HI THERE on a blue background.

We should detect \e (and other characters like space) and escape it in cli encoder

Contributor guide

Research direction
Locate the CLI encoder for `ipfs ls` in the codebase (likely in the commands package). Identify where the output is printed and add escaping for escape sequences (\e) and other special characters like spaces. Use Go's string escaping or a library to ensure safe output.
Tech stack
go
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75