ipfs/kubo

`ipfs stats bw` doesn't support --enc json

Open

#5594 opened on Oct 12, 2018

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Go (13,906 stars) (2,725 forks)batch import
P3effort/daysexp/experthelp wantedkind/bug

Description

Version information:

go-ipfs 0.4.17 and git master

Type:

Bug

Description:

All commands should support the --enc options. It doesn't work for ipfs stats bw I suppose because the result of the command is formatted in a PostRun instead of an Encoders.

Contributor guide

Tech stack
go
Domain
cli
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go programmingIPFS codebase familiarityCLI command structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate how other commands implement the ` enc` flag for JSON output. Look at the command definition for `stats bw` in the codebase, likely in `core/commands/` directory. The issue mentions the result is formatted in a `PostRun` instead of using an `Encoders`, so examine the `PostRun` function for `stats bw` and compare with commands that support ` enc` (e.g., `ipfs files ls`). Also check if there is an encoder registration missing. Consider adding the encoder or refactoring to use the standard encoder pattern.