ipfs/kubo

Test the progress bar on add

Open

#5366 opened on Aug 10, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Go (13,906 stars) (2,725 forks)batch import
exp/experthelp wantedkind/teststatus/deferred

Description

We currently have no progress bar tests. We should fix this. Specifically, I'd like to test #5288. When uploading a directory containing directories, the progress bar should reach 100%. We don't have to test the display, just the response from the server (may be best to parse the JSON? in bash? without jq?).

Contributor guide

Tech stack
go
Domain
backendtesting
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
GoIPFS basicsbash
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Start by examining the existing test suite for the 'add' command, likely in `core/commands/add test.go`. There may be a test helper for simulating uploads. Also look at issue #5288 for context. Focus on parsing the JSON response from the server to verify the progress reaches 100%.