ipfs/kubo

PUT existing file with Writeable Gateway not returning expected result.

Open

#3923 opened on May 13, 2017

View on GitHub
 (6 comments) (0 reactions) (0 assignees)Go (13,906 stars) (2,725 forks)batch import
help wantedkind/bugtopic/gateway

Description

Version information:

go-ipfs version: 0.4.8- Repo version: 5 System version: amd64/linux Golang version: go1.8

Type:

Bug

Severity:

Medium

Description:

When using a writeable HTTP gateway:

  • If I PUT to a directory tree for a path that doesn't exist in the tree, the gateway returns the expected result: the ipfs-hash for an edited directory tree that contains the uploaded file at the specified path.
  • However, if I PUT to a directory tree for a path that already exists in the tree, I instead get back the ipfs-hash for the file I uploaded- as if I had used the POST interface.
  • I would expect, in that case, to receive the ipfs-hash of the root of an edited directory tree that contains the uploaded file in place of the path's former content.

Contributor guide

Tech stack
go
Domain
backendapi
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic understanding of IPFSFamiliarity with GoKnowledge of HTTP PUT semantics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the writeable HTTP gateway implementation in the kubo repository, specifically the PUT handler. The bug report indicates that PUT on an existing path returns the hash of the uploaded file instead of the hash of the updated directory tree. Look at the gateway code, likely in 'core/commands/' or 'gateway/' directories, and check how path resolution and file replacement are handled. The expected behavior is to return the root hash of the directory tree after replacing the file. Compare with the POST behavior to identify the discrepancy.