ipfs/kubo

/ipfs/ and /ipns/ links don't work from a dnslink hosted web space

Open

#3,902 opened on May 5, 2017

View on GitHub
 (6 comments) (2 reactions) (0 assignees)Go (2,725 forks)batch import
help wanted

Repository metrics

Stars
 (13,906 stars)
PR merge metrics
 (Avg merge 4d 2h) (28 merged PRs in 30d)

Description

Version information:

go-ipfs version: 0.4.9-rc1- Repo version: 5 System version: amd64/darwin Golang version: go1.8

Type: Bug

Severity: Medium

Description:

When accessing IPFS via a dnslink-serviced host (e.g. ipfs.sallings.org), /ipfs/ and /ipns/ links don't work.

e.g.,:

http://ipfs.sallings.org/ipns/QmP8uqUuowHdixyFASba87ABgVxfoKGj8NyrTH2VLLTFkZ

yields:

ipfs resolve -r /ipns/ipfs.sallings.org/ipns/QmP8uqUuowHdixyFASba87ABgVxfoKGj8NyrTH2VLLTFkZ: no link named "ipns" under QmaYYjrg1rEYddWYLcR96uc9jGLA9cuHkUiCqQYLwbKDnx

I would expect either ipfs or ipns to be handled in this case when it can't be resolved directly (or just always).

This seems minor, but I considered it "medium" severity as it means you can't link to separately managed pages within IPFS from such a host. In the above case, I worked around this by linking to //gateway.ipfs.io/ipns/... -- but this is quite undesirable for a variety of reasons (e.g., can't just browse stuff at localhost).

Contributor guide

Research direction
Inspect the dnslink resolution logic in the gateway handler. Trace the path resolution for /ipfs/ and /ipns/ under a dnslink host.
Tech stack
go
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65