ipfs/kubo

Investigate add/pin/gc locking

Open

#3,514 opened on Dec 16, 2016

View on GitHub
 (1 comment) (1 reaction) (0 assignees)Go (2,725 forks)batch import
help wantedkind/testtopic/commands:addtopic/repo

Repository metrics

Stars
 (13,906 stars)
PR merge metrics
 (Avg merge 4d 2h) (28 merged PRs in 30d)

Description

While looking into #3470 and #3436, I found that the locks around adding/pinning/GC look really wonky and inconsistent.

This issue is a reminder that we need to:

  • Look very closely at which locks are in play
  • Document in detail how these locks work
  • Write stress tests which make sure we don't end deadlock ourselves

Contributor guide

Research direction
Examine the existing locking mechanisms in add, pin, and garbage collection code paths. Trace the lock acquisitions and releases, identify inconsistencies, and document the lock hierarchy. Write stress tests to verify deadlock freedom.
Tech stack
go
Domain
backend
Issue type
Research
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GoConcurrency
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30