ipfs/kubo

Investigate add/pin/gc locking

Open

#3514 opened on Dec 16, 2016

View on GitHub
 (1 comment) (1 reaction) (0 assignees)Go (13,906 stars) (2,725 forks)batch import
help wantedkind/testtopic/commands:addtopic/repo

Description

While looking into #3470 and #3436, I found that the locks around adding/pinning/GC look really wonky and inconsistent.

This issue is a reminder that we need to:

  • Look very closely at which locks are in play
  • Document in detail how these locks work
  • Write stress tests which make sure we don't end deadlock ourselves

Contributor guide

Tech stack
go
Domain
backend
Issue type
research
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Go concurrencyIPFS internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
15
Research direction
Investigate the locking mechanisms around add/pin/GC operations in the IPFS Go implementation (kubo). Start by examining the code referenced in issues #3470 and #3436. Document the current lock usage, identify inconsistencies, and propose a consistent locking strategy. Finally, write stress tests to ensure deadlock free operation.