ipfs/kubo

merkledag: CumulativeSize on directories overflows

Open

#3,440 opened on Nov 29, 2016

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Go (2,725 forks)batch import
help wantedkind/bugstatus/deferred

Repository metrics

Stars
 (13,906 stars)
PR merge metrics
 (Avg merge 4d 2h) (28 merged PRs in 30d)

Description

Version information: 0.4.5

Type: bug

Priority: P4

Description:

CumulativeSize of a directory (or file) can reach ~16 EB maximum, after which it wraps around to 0B. An example showing this overflow: QmW4Zd911qv7uaRM2vi79YsfHvZ93skxiCxLnwpgpf7hp3 The directory looks like 11GB, but contains a lot of 'large' folders (like a zip bomb) + a data folder (here, the npm repo) of 723 GB. Here's the folder bomb used.

Contributor guide

Research direction
Investigate the CumulativeSize calculation in the merkledag package to prevent integer overflow by using a larger integer type or overflow detection.
Tech stack
go
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75