ipfs/kubo

Config set fails if there is entry in config that is integer bigger than 1e6

Open

#3,354 opened on Nov 4, 2016

View on GitHub
 (6 comments) (0 reactions) (0 assignees)Go (2,725 forks)batch import
exp/experthelp wantedkind/bugstatus/deferredtopic/api

Repository metrics

Stars
 (13,906 stars)
PR merge metrics
 (Avg merge 4d 2h) (28 merged PRs in 30d)

Description

I have BloomSize set to 1048576, if I then try to do any config call, example

ipfs config --json API.HTTPHeaders.Access-Control-Allow-Origin '["*"]'

I get:

Error: failed to set config value: Failure to decode config: json: cannot unmarshal number 1.048576e+06 into Go value of type int (maybe use --json?)

The integer is being transformed into floating point at some point.

Contributor guide

Research direction
Investigate how the config values are serialized/deserialized, focusing on JSON unmarshaling of large integers that get converted to exponential notation.
Tech stack
go
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoJSON
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70