ipfs/kubo

Pass metrics collection through the root context of an ipfs node

Open

#3,212 opened on Sep 12, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Go (13,906 stars) (2,725 forks)batch import
help wantedstatus/deferred

Description

After #3189 lands, we are starting to use contexts to perform metrics collection. To really make this nice, we should pass the metrics collector down through the context chain. Doing so will make metrics collection throughout the codebase much easier to test and reason about.

This will require us to fix: https://github.com/jbenet/goprocess/issues/16

Contributor guide

Tech stack
go
Domain
backendobservability
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go programmingContext passing patternsMetrics collection concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Review the changes from pull request #3189 to understand how metrics collection is integrated with contexts. Then examine goprocess issue #16 to identify the required fix for context propagation. Look at the current root context setup in the IPFS node (e.g., core/node.go) to determine where to insert the metrics collector and pass it down.