ipfs/kubo

NoAnnounce should work for /dns addresses added by AutoTLS

Open

#10830 opened on Jun 6, 2025

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Go (13,906 stars) (2,725 forks)batch import
P2exp/intermediatehelp wantedkind/bug

Description

Checklist

  • My issue is specific & actionable.
  • I am not suggesting a protocol enhancement.
  • I have searched on the issue tracker for my issue.

Description

It seems that AutoTLS will figure out external IPs on ipv4 and ipv6 and add dns announce addresses accordingly. It does not take into account whether the IPs pointed to by these addresses are in the NoAnnounce filter.

Contributor guide

Tech stack
go
Domain
backendinfrastructure
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic knowledge of IPFSfamiliarity with Gounderstanding of AutoTLS feature
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Start by examining the AutoTLS implementation in the IPFS kubo repository, likely in the Go files under the 'config' or 'p2p' directories. Look for where DNS announce addresses are generated and where the NoAnnounce filter is applied. The bug is that AutoTLS does not check the NoAnnounce filter when adding announce addresses. Check the AutoTLS configuration and routing logic to see how addresses are added and ensure they respect the NoAnnounce filter.