ipfs/ipfs-desktop

Import file modal doesn't stay open when switching apps

Open

#2182 opened on Jun 20, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (5,632 stars) (912 forks)batch import
P2effort/dayshelp wantedkind/bugstatus/readytopic/design-front-end

Description

Describe the bug I was attempting to import a file from IPFS when I noticed this error because I had to switch back to my browser to copy the CID and name. After pasting one of the values, switching to the browser, copying the other value, and switching back to IPFS Desktop, the modal with the first value is still there, but immediately gets removed. This shouldn't happen.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Files'
  2. Click on 'Import'
  3. Click on 'From IPFS'
  4. Paste some value into either field
  5. Switch focus to another app
  6. Switch focus back to IPFS Desktop
  7. Notice that the modal and originally entered value is gone.

Expected behavior I expected the modal to remain there, with the value I initially entered.

This bug does not happen in ipfs-webui (tested at localhost:5001)

Screenshots ipfs_ipfs-desktop_issues_2182

Additional context error.log

combined.log

Contributor guide

Tech stack
javascriptnodejsreact
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptNode.jsReactElectron
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the modal component for the 'From IPFS' import in IPFS Desktop. Compare the behavior with ipfs webui. Look for blur or focus event handlers that might reset the modal state. Likely files: src/components/ or src/modals/ directory. Check if there is a listener that clears the modal on window blur.