ipfs/ipfs-desktop

Slow test file: test/e2e/launch.e2e.test.js (42s)

Open

#2,116 opened on Apr 29, 2022

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (5,632 stars) (912 forks)batch import
P3exp/intermediategood first issuehelp wantedkind/maintenancestatus/deferred

Description

We should optimize and speed up these tests.

npm run test:e2e

> ipfs-desktop@0.20.5 test:e2e
> xvfb-maybe cross-env NODE_ENV=test playwright test test/e2e/launch.e2e.test.js


Running 10 tests using 1 worker

  ✓  test/e2e/launch.e2e.test.js:66:3 › Application launch › creates a repository on startup (5s)
  ✓  test/e2e/launch.e2e.test.js:80:3 › Application launch › starts fine when node is already running (4s)
  ✓  test/e2e/launch.e2e.test.js:88:3 › Application launch › applies config migration (MDNS.enabled) (4s)
  ✓  test/e2e/launch.e2e.test.js:109:3 › Application launch › applies config migration (Web UI CORS 1) (4s)
  ✓  test/e2e/launch.e2e.test.js:131:3 › Application launch › applies config migration (Web UI CORS 2) (4s)
  ✓  test/e2e/launch.e2e.test.js:152:3 › Application launch › applies config migration (Web UI CORS 3) (4s)
  ✓  test/e2e/launch.e2e.test.js:173:3 › Application launch › applies config migration (ConnMgr) (4s)
  ✓  test/e2e/launch.e2e.test.js:194:3 › Application launch › starts with repository with "IPFS_PATH/api" file and no daemon running (6s)
  ✓  test/e2e/launch.e2e.test.js:210:3 › Application launch › starts with multiple api addresses (4s)
  ✓  test/e2e/launch.e2e.test.js:222:3 › Application launch › starts with multiple gateway addresses (4s)

  Slow test file: test/e2e/launch.e2e.test.js (42s)
  Consider splitting slow test files to speed up parallel execution

  10 passed (42s)

Contributor guide

Tech stack
javascriptplaywright
Domain
testingperformance
Issue type
performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of PlaywrightUnderstanding of e2e test structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue identifies test/e2e/launch.e2e.test.js as a slow test file taking 42 seconds. To optimize, examine the 10 test cases in that file and determine if they can be split into separate files or if parallel execution can be increased. Look for independent tests that don't share state and consider grouping them differently. The Playwright configuration and CI setup should also be reviewed to allow multiple workers. The goal is to reduce the overall test execution time without breaking existing tests.