ipfs/ipfs-desktop

Uninstall don't delete %AppData%

Open

#1864 opened on Jun 25, 2021

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (5,632 stars) (912 forks)batch import
P2area/windowseffort/hoursgood first issuehelp wantedstatus/ready

Description

  • OS: Windows
  • Version of IPFS Desktop 0.16.0

Describe the bug The following folders are created by IPFS-Desktop while it's being used by the user:

%AppData%\Roaming\IPFS Desktop %USERPROFILE%\.ipfs %USERPROFILE%\.ipfs-desktop

None of which will be removed when IPFS-Desktop will be uninstalled.

Following the principle of the least surprise this should be the case, as this is the warn message Windows shows when uninstalling an application:

ipfs_desktop_screenshot_bugreport_no_data_cleanup_on_uninstall_uninstall_message

To Reproduce Steps to reproduce the behavior:

  1. Use IPFS Desktop
  2. Uninstall it via the Settings -> Apps
  3. Complete the uninstall procedure
  4. Look at the quoted paths, which still exist

Expected behavior All data associated with IPFS Desktop should be removed when uninstalling.

Contributor guide

Tech stack
javascriptnodejselectron
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with Electron app structureKnowledge of electron builder or NSIS installerWindows file system permissions
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Investigate the uninstall configuration in the repository, likely in electron builder.yml or a custom NSIS script. The folders to delete are %AppData%\Roaming\IPFS Desktop, %USERPROFILE%\.ipfs, and %USERPROFILE%\.ipfs desktop. Check the existing uninstall process and add steps to remove these directories. Ensure that user data is deleted only on uninstall, not during upgrades.