ipfs/ipfs-desktop

macos: cmd + q should close the window not quit the app.

Open

#1,811 opened on Apr 28, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (912 forks)batch import
P2area/macoseffort/hoursgood first issuehelp wantedkind/enhancement

Repository metrics

Stars
 (5,632 stars)
PR merge metrics
 (Avg merge 8d 12h) (6 merged PRs in 30d)

Description

IPFS Desktop wants to help you keep your IPFS daemon running. Looking at other vaguely similar apps, they follow the pattern of running in the menubar, and cmd + q causes the open window to close, but does not quit the app. It continues to run in the menubar

Apps i've tested which do this

  • Docker Desktop - closes the window, keeps docker in menubar, keeps docker daemon running
  • Postgres.app - closes the window, keeps postgress in menubar, leaves postgres running.
  • Keybase - closes window, keeps keybase in menubar

Contributor guide

Research direction
Modify the Electron main process to intercept the 'will quit' event or use a global shortcut to override cmd+Q on macOS, then hide the window instead of quitting the app. Ensure the app continues running in the menubar.
Tech stack
javascript
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptElectron
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60