ipfs/ipfs-desktop

Ignore single left click on tray icon

Open

#1,772 opened on Feb 25, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (912 forks)batch import
P2area/windowsexp/beginnergood first issuehelp wantedstatus/ready

Repository metrics

Stars
 (5,632 stars)
PR merge metrics
 (Avg merge 8d 12h) (6 merged PRs in 30d)

Description

  • OS: Windows
  • Version of IPFS Desktop: 0.14.0

Describe the bug After implementing opening of app's window on a double click on tray icon, a single click with left mouse button still opens the context menu even when doing double click. So, the first left click quickly opens the menu until the second left click is done.

To Reproduce Steps to reproduce the behavior:

  1. Do a left click on the tray icon and the context menu will appear.
  2. Do a left double click on the tray icon and the context menu will quickly appear on the first click and disappear on the second.

Expected behavior Usually Windows apps are designed so that if tray icon menu opens with the right click, the single left click is just ignored.

Contributor guide

Research direction
Look at the tray icon implementation in the main process. Identify where left click events are handled and modify to ignore single left clicks or differentiate between single and double clicks.
Tech stack
javascript
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80