ipfs/ipfs-companion

Recreate Test Suite

Open

#145 opened on Sep 14, 2016

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (364 forks)batch import
help wantedkind/maintenancestatus/deferred

Repository metrics

Stars
 (1,992 stars)
PR merge metrics
 (Avg merge 53d 3h) (1 merged PR in 30d)

Description

In legacy SDK we had a comprehensive test suite that was run via jpm test

WebExtensions use web-ext, but it does not provide test runner yet. There is a related, open issue at https://github.com/mozilla/web-ext/issues/5.

This issue is blocked until WebExtension test runner is implemented upstream, or a custom npm tests command is implemented locally AND we reach 80%+ test coverage

(updated 2017-12-02)

  • npm test runs test suite with browser stub
  • think about Browser detection (we have Firefox/Chrome/Brave specific workarounds in codebase)
  • TODO: go over tests in legacy-sdk branch and add missing unit tests here
  • Research if we are able to run integration tests against real browsers with assertions that check browser UI
    • https://firefox-puppeteer.readthedocs.io:

      Firefox Puppeteer provides a library to manipulate each visual section of Firefox’s browser UI. For example, there are different libraries for the tab bar, the navigation bar, etc.

Contributor guide

Research direction
Review the legacy test suite at the linked branch, identify missing unit tests, and investigate the status of web ext test runner or implement a custom npm test command with browser stubs.
Tech stack
javascript
Domain
frontendtesting
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
JavaScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70