ipfs/ipfs-companion

Refactor View Containers

Open

#1,252 opened on Aug 2, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (1,992 stars) (364 forks)batch import
P1effort/hoursexp/intermediategood first issuehelp wantedpost-mv3

Description

The request permission view: https://github.com/ipfs/ipfs-companion/pull/1250

is a duplicate from https://github.com/ipfs/ipfs-companion/tree/main/add-on/src/recovery which intern is a duplicate from https://github.com/ipfs/ipfs-companion/tree/main/add-on/src/landing-pages/welcome

The stores used are common, the styles used are common, we can refactor those screens such that we don't end up recreating these again and again.

### Tasks
- [ ] Unify Styles
- [ ] Unify Stores
- [ ] Unify Screen rendering logic

Contributor guide

Tech stack
javascripthtmlcss
Domain
frontend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptHTML/CSSGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Start by examining the three duplicated view files: add on/src/recovery, add on/src/landing pages/welcome, and the pull request #1250 for the request permission view. Identify common styles, stores, and rendering patterns. Then propose a unified component structure, refactoring the duplicate code into shared modules.