ipfs/ipfs-companion

Numbers of peers past 1000 get cut off in the toolbar

Open

#1,017 opened on Aug 5, 2021

View on GitHub
 (2 comments) (2 reactions) (0 assignees)JavaScript (364 forks)batch import
P3exp/novicegood first issuehelp wantedkind/enhancementtopic/design-visual

Repository metrics

Stars
 (1,992 stars)
PR merge metrics
 (Avg merge 53d 3h) (1 merged PR in 30d)

Description

Describe the bug Any number of peers past 1000 gets cut of in the toolbar To Reproduce Steps to reproduce the behaviour:

  1. Connect to over 1000 peers (Enabling AcceleratedDHTClient and DHT server mode helps with that)
  2. Look at the extension icon

Expected behaviour The number does not get cut off

Screenshots

Desktop (please complete the following information):

  • OS: macOS 12.0 Beta (21A5294g)
  • Browser: Firefox
  • Version: 92.0a1 (2021-08-05) (64-bit)

Contributor guide

Research direction
Inspect the toolbar component's CSS for the peer count element, ensuring text overflow and width are set correctly to display numbers up to 4 digits.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
CSSHTML
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90