ipfs/ipfs-companion

Import to Files on My Node does not work on disabled origins

Open

#1,000 opened on May 10, 2021

View on GitHub
 (0 comments) (0 reactions) (1 assignee)JavaScript (364 forks)batch import
P1help wantedkind/bug

Repository metrics

Stars
 (1,992 stars)
PR merge metrics
 (Avg merge 53d 3h) (1 merged PR in 30d)

Description

v2.19.0 introduced "Import to Files on My Node" feature in the main browser action menu:

2021-05-10--13-53-29

User can disable IPFS integrations on specific origin, and when that happens, this feature does nothing.

We need to either:

  • wire things up so the proper /ipns/{dnslink-name} content path is used, even when page is at https://{dnslink-name}
  • OR fade out this option so it is obvious it is deactivated

Contributor guide

Research direction
Examine the code path for 'Import to Files on My Node' in the browser action menu. Identify how disabled origins are detected and where the fallback logic should insert the correct /ipns/{dnslink name} path.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Gitbrowser extension development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40