ipfs/ipfs-companion

Import to Files on My Node does not work on disabled origins

Open

#1,000 opened on May 10, 2021

View on GitHub
 (0 comments) (0 reactions) (1 assignee)JavaScript (1,992 stars) (364 forks)batch import
P1help wantedkind/bug

Description

v2.19.0 introduced "Import to Files on My Node" feature in the main browser action menu:

2021-05-10--13-53-29

User can disable IPFS integrations on specific origin, and when that happens, this feature does nothing.

We need to either:

  • wire things up so the proper /ipns/{dnslink-name} content path is used, even when page is at https://{dnslink-name}
  • OR fade out this option so it is obvious it is deactivated

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptbrowser extension fundamentalsIPFS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Examine the browser action popup code (likely under src/popup) to understand how the 'Import to Files on My Node' button is implemented. Investigate how disabled origins are tracked and where the content path resolution occurs. The two proposed solutions involve either modifying the popup to use the proper /ipns/{dnslink name} content path or graying out the option when the origin is disabled. Check if the assignee has left any comments or linked PRs for additional context.
Import to Files on My Node does not work on disabled origins · ipfs/ipfs-companion#1000 | Good First Issue