ipfs/distributions

dist.sh should check that the new version is newer than the current version

Open

#319 opened on Oct 23, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Less (31 forks)auto 404
P2dif/easyeffort/hoursgood first issuehelp wantedkind/maintenancestatus/ready

Repository metrics

Stars
 (49 stars)
PR merge metrics
 (PR metrics pending)

Description

A note-to-self to make dist.sh verify that the new-version is in fact newer in semver terms than the current version... we avoid setting release candidates as current, but we dont guard against setting older versions as current. Minor but feels like a foot gun.

https://github.com/ipfs/distributions/blob/211588d697902572642a53d20b2ff5d121ecd1b9/dist.sh#L58-L63

Contributor guide

Research direction
Explore implementing a semver comparison function or using an existing tool within the shell script to ensure the new version is greater than the current version before setting it as current.
Tech stack
shell
Domain
devops
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Shell scriptingsemver
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70