iovisor/bcc

update killsnoop to use tracepoints

Open

#3,592 opened on Aug 27, 2021

View on GitHub
 (7 comments) (0 reactions) (1 assignee)C (4,073 forks)batch import
help wanted

Repository metrics

Stars
 (22,632 stars)
PR merge metrics
 (PR metrics pending)

Description

This is a request for help.

I wrote killsnoop back in 2015 before tracepoint support, and so I kprobe'd sys_kill(). It still does some derivation of that. But now there's a report it no longer works on Linux 5.11: https://github.com/iovisor/bcc/pull/3572#issuecomment-900357032 CC @chenhengqi

Can someone please update killsnoop (both Python and libbpf-tools) to use tracepoints instead of kprobes (if it works as expected). All of these:

  syscalls:sys_enter_kill                            [Tracepoint event]
  syscalls:sys_enter_tgkill                          [Tracepoint event]
  syscalls:sys_enter_tkill                           [Tracepoint event]
  syscalls:sys_exit_kill                             [Tracepoint event]
  syscalls:sys_exit_tgkill                           [Tracepoint event]
  syscalls:sys_exit_tkill                            [Tracepoint event]

Contributor guide

Research direction
Update killsnoop (both Python and libbpf tools) to use tracepoints instead of kprobes. Examine the existing kprobe based implementation and replace with the listed syscall tracepoints.
Tech stack
cpython
Domain
observability
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
BPFtracepointsC
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50