ionic-team/ionicons

Can you expose a part="svg" for the SVG content

Open

#960 opened on Apr 16, 2021

View on GitHub
 (5 comments) (9 reactions) (0 assignees)TypeScript (17,256 stars) (2,083 forks)batch import
help wanted

Description

When using it with custom icons : <ion-icon src="assets/icons/wifi.svg"></ion-icon> Because of the Shadow DOM we can't style at all the content of the SVG. Any custom SVG used is always a square because of the this css lines : https://github.com/ionic-team/ionicons/blob/8c2a507fcff2cb5f2edff60357ffd7feb70bb987/src/components/icon/icon.css#L27-L34 By adding a part="svg" it would be possible to have more flexibility to style the SVG from the outside. In my case setting height to auto, but it could be to change the color of a specific path or anything else.

Contributor guide

Tech stack
typescriptweb components
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of Shadow DOMFamiliarity with CSS partsIonIcons component structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
To implement this feature, locate the icon component's template in the IonIcons source code, specifically the file referenced in the issue (src/components/icon/icon.css and related tsx/html). Add the part='svg' attribute to the SVG element inside the component's shadow DOM. Ensure that the change does not break existing functionality and that the SVG is properly exposed for external styling via CSS part selectors. Test with a custom SVG icon to verify that the part attribute is applied and styling works.