ionic-team/ionicons

Loading svg fails when base-href set

Open

#707 opened on Jul 7, 2019

View on GitHub
 (7 comments) (0 reactions) (0 assignees)TypeScript (17,256 stars) (2,083 forks)batch import
help wantedtype: bug

Description

I am using angular 7.2.2 with ionic 4.6.0.

Everything is fine until i prepare my final deployment where base-href is set to some "/context/path/". Everything keeps working except ionicon resolution, still requesting the resources from "/svg/iconname.svg".

Anything i can do beside hardcoding the src myself?

Contributor guide

Tech stack
typescriptangular
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Angularbase href concept
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
Investigate how ionicons resolves SVG paths. The issue likely stems from using absolute '/svg/...' paths instead of relative or base href aware paths. Check the ion icon component's source code for URL construction, and consider using Angular's APP BASE HREF or a custom configuration. Look at community comments for workarounds.