ionic-team/ionicons

ion icons not displayed if they are hosted on a server requesting auth

Open

#640 opened on Nov 23, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (17,256 stars) (2,083 forks)batch import
help wantedtype: bug

Description

I'm submitting a:

[x] bug report [ ] feature request [ ] support request

ionicons version:

 ionicons v4.4.6

Current behavior: Currently the icon class gets the svg content without sending the cookies in microsoft edge on desktop and in every navigator on iPad. By default, fetch won't send or receive any cookies from the server, resulting in unauthenticated requests if the site relies on maintaining a user session (to send cookies, the credentials init option must be set). This means that those svgs can't be hosted on a server requesting auth.

Expected behavior: I would expect that a credentials init option is set to same-origin or include.

If there are cases I haven't thought of, please let me know. I'd also be happy with a config option to change the value.

Contributor guide

Tech stack
typescript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic understanding of fetch APIFamiliarity with HTTP cookies
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The issue is about the fetch call not including credentials when loading SVG icons. Look for the code that fetches SVG content, likely in a loader module under `src/`. The fix is to add `credentials: 'same origin'` or `include` option to the fetch call. There are 2 comments in the issue; review them for any additional context. Consider if a config option is desired by maintainers.