ionic-team/ionicons

incorrect icon: Improve close / checkmark icon.

Open

#1195 opened on Mar 14, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (17,256 stars) (2,083 forks)batch import
help wantedtype: incorrect icon

Description

Describe the Issue

Just a minor but somewhat annoying issue from a meticulous UI dev. Especially when using close and checkmark icon together. It seems that either the close is not correct or checkmark. You can decide.

Comparison

Type Close Checkmark Compare Comment
outline 1-close 1-checkmark compare-outline Seems ok.
filled 2-close 2-checkmark compare-filled The close appears too thick or the checkmark too thin.
sharp 3-close 3-checkmark compare-sharp Seems ok.

close checkmark

We see that the checkmark outline and filled appear the same. The filled checkmark should be thicker or the cross thinner.

Contributor guide

Tech stack
typescript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
The issue compares close and checkmark icons across outline, filled, and sharp variants. The filled variant appears inconsistent. To resolve, locate the SVG source files for these icons in the repository (likely in src/svg), compare stroke width attributes, and adjust one to match the other. Maintainer input may be needed to decide which icon's stroke thickness to change. Check any existing icon guidelines for consistent stroke widths.