content: Angular PWA guide is missing the angular.json step for Angular 18+

Open Beginner friendly
#4,702 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
Half a day
Newbie friendliness
78/100
Issue type
Documentation
Clarity
Mostly clear
Activity status
Active
Tech stack
angular
Domain
documentation

Research direction

Open the Angular PWA guide at https://ionicframework.com/docs/angular/pwa and review the setup instructions, especially the ng add step and the ngsw-config.json sample. Document the angular.json assets entry with { "glob": "**/*", "input": "public" } and refresh the sample for Angular 18+; done means the guide covers the generated public files and web-root manifest behavior.

Written by the indexing model from the issue text.

Description

content package: angular
URL

https://ionicframework.com/docs/angular/pwa

Issue Description

The guide's only setup step is ng add @angular/pwa, which was accurate before Angular 18 but is no longer sufficient for a project created with ionic start.

Since Angular 18 the pwa schematic writes manifest.webmanifest and the icons to public/ and no longer adds an entry to angular.json. The Ionic starter's angular.json has no public asset glob, so those files are never copied into www/. On a host with a SPA rewrite the 404 is served as index.html and the browser reports Manifest: Line: 1, column: 1, Syntax error.

The page should tell readers to add the public glob to the assets array after running the schematic:

{ "glob": "**/*", "input": "public" }

Note there is deliberately no output key, so the files land at the web root and match the <link rel="manifest" href="manifest.webmanifest"> the schematic injects into index.html.

The ngsw-config.json sample on the page is also stale relative to what Angular 18+ generates and worth refreshing at the same time.

Reported in ionic-team/starters#1888, which covers the starter-side fix.

Dominant language
MDX
Stars
621
Forks
3.2k
Avg merge
1d 2h
Merged PRs (30d)
86

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ionic-team/ionic-docs

All issues in ionic-team/ionic-docs

Similar issues

More Documentation issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.