iodide-project/iodide

Binary dragged & dropped files should not be fetched as text by default

Open

#2,456 opened on Nov 19, 2019

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (1,483 stars) (147 forks)batch import
good first issuehelp wanted

Description

Steps to reproduce:

  • drag & drop a binary file into iodide main page (e.g. an excel file called Furniture_only.xls)

Expected:

%% fetch
blob: file0=Furniture_only.xls

Got:

%% fetch
text: file0=Furniture_only.xls

It is still a pain to do something with the excel file (#2447) but the fact that we're fetching the file as text is yet another roadblock. Perhaps we could sniff the type of the uploaded file and then set this property of the created notebook accordingly? @hamilton / @openjck any thoughts on this?

Contributor guide

Tech stack
javascripthtmlcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
File APIMIME type detectionIodide notebook format
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the drag and drop event handlers in the iodide frontend to find where the fetch command is generated. Modify the code to detect binary file MIME types and use 'blob' instead of 'text' for those files. Refer to the existing file handling logic in the repository.