iodide-project/iodide

EXPLORE/REPORT button should just be one instance of one component

Open

#1673 opened on Mar 26, 2019

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (1,483 stars) (147 forks)batch import
UI appearancebugclient UXgood first issue

Description

the explore/report button is currently actually two components. it should really just be one component that toggles its text+appearance, because it's conceptually just one thing, and not moving it during the transition will also fix a tooltip bug

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
React component basicsunderstanding of button's usage
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Locate the two separate components for the explore and report buttons, likely in the components directory. Consolidate them into a single component with a prop to toggle text and appearance. Ensure the tooltip bug (mentioned as caused by moving the button) is fixed by keeping the same DOM element. Review the 3 existing comments for any additional context or requirements.