invertase/react-native-firebase-starter

[help-wanted] Add tests example

Open

#21 opened on Apr 13, 2018

View on GitHub
 (2 comments) (6 reactions) (0 assignees)JavaScript (1,174 stars) (346 forks)batch import
enhancementhelp wanted

Description

After following the getting started instructions, running npm test results in an error:

 FAIL  ./App.test.js
  ● Test suite failed to run

    RNFirebase core module was not found natively on iOS, ensure you have correctly included the RNFirebase pod in your projects `Podfile` and have run `pod install`.

     See http://invertase.link/ios for the ios setup guide.

       9 | } from 'react-native'
      10 |
    > 11 | import firebase from 'react-native-firebase'
      12 |
      13 | export default class App extends React.Component {
      14 |   constructor () {
      Error: RNFirebase core module was not found natively on iOS, ensure you have correctly included the RNFirebase pod in your projects `Podfile` and have run `pod install`.

This has already been reported in the react-native-firebase repo and it appears this is expected behavior - according to that thread RNFirebase needs to be mocked out for the tests to work.

Assuming that's all correct, I would propose adding a basic mock for RNFirebase to this starter project and enabling it by default.

Contributor guide

Tech stack
javascriptreact
Domain
mobiletesting
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Jest mockingReact NativeFirebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Create a mock for the react native firebase module in the test setup (e.g., in a mocks directory) as described in the referenced issue. The mock should simulate the native module to allow tests to run without a real device. Update the test file App.test.js to include the mock. See the discussion in https://github.com/invertase/react native firebase/issues/817 for guidance on expected mock behavior.