Space needed between multiple name identifiers

Open Beginner friendly
#306 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
javascript
Domain
frontend

Research direction

Start in src/lib/elements/contrib/invenioRDM/records/AffiliationsSuggestions.js and inspect the makeIdEntry and AffiliationsSuggestions functions. Reproduce the issue in the deposit form with a name containing multiple non-standard identifiers. Done means each identifier is separated by a space, including before the following identifier scheme.

Written by the indexing model from the issue text.

Description

bug

Package version (if known): HEAD (seen on invenio-app-rdm@13.0.2)

Describe the bug

When a name has multiple identifiers, they are sometimes combined with no space in between. This is visually unpleasing but also breaks screenreaders since they're reading not the identifier but the identifier with the next identifiers scheme postfixed.

Steps to Reproduce

  1. Create a name with multiple identifiers not in the list of makeIdEntry cases (orcid, gnd, ror, isni, grid), example:
- affiliations:
  - id: 01mmcf932
  family_name: Phetteplace
  given_name: Eric
  id: https://portal.cca.edu/people/ephetteplace/
  identifiers:
  - identifier: https://portal.cca.edu/people/ephetteplace/
    scheme: url
  - identifier: ephetteplace@cca.edu
    scheme: email
  1. Go to the deposit form
  2. Add a Creator or Contributor
  3. Search for a string that will bring up the name, e.g. "Phetteplace"
  4. The two id strings are stuck together: url: https://portal.cca.edu/people/ephetteplace/email: ephetteplace@cca.edu

Expected behavior

There should be a space in between each identifier and the scheme of the following one: url: https://portal.cca.edu/people/ephetteplace/ email: ephetteplace@cca.edu

Screenshots (if applicable)

Image

Additional context

This occurs in src/lib/elements/contrib/invenioRDM/records/AffiliationsSuggestions.js and could be fixed in either the makeIdEntry or AffiliationsSuggestions functions. I will submit a small PR.

Dominant language
JavaScript
Stars
2
Forks
37
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from inveniosoftware/react-invenio-forms

All issues in inveniosoftware/react-invenio-forms

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.