intitni/CopilotForXcode

Accept button on floating window doesn't work

Open

#70 opened on Mar 23, 2023

View on GitHub
 (15 comments) (0 reactions) (0 assignees)Swift (8,256 stars) (426 forks)batch import
help wanted

Description

I'm experiencing a weird problem that on the suggestion floating window, the Accept button doesn't work. When I click on it, nothing happens. The suggestion isn't applied to the code, and the floating window doesn't disappear either.

スクリーンショット 2023-03-24 2 31 44

The reject button works as expected that no code changes and the floating window disappears.

I can accept it from Menu bar though

スクリーンショット 2023-03-24 2 32 40

But since it's too inconvenient so I've set a key binding to accept it as a workaround.

Is there anybody having the same problem?

My environment:

  • Chip: M1 Max
  • macOS: 13.2.1（22D68）
  • Xcode: 14.2 (14C18)
  • Copilot for Xcode: 0.8.6 (49)

Contributor guide

Tech stack
swift
Domain
developer experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
SwiftXcode extension developmentUI event handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue is that the Accept button on the floating suggestion window does not respond to clicks, while the Reject button works. This suggests a problem with the button's action handler or gesture recognizer. Investigate the view hierarchy and event handling in the SuggestionsView or similar component. Check the Xcode extension's UI code for missing target action connections or gesture conflicts. Look for recent commits or related issues that might have introduced a regression in the button's functionality.