internetarchive/openlibrary

Edition's bookcover alt-text should pull author from work

Open

#486 opened on Apr 28, 2017

View on GitHub
 (26 comments) (0 reactions) (1 assignee)Python (4,626 stars) (1,172 forks)batch import
Affects: DataAffects: ServerAffects: UIGood First IssueLead: @cdriniNeeds: ResponsePriority: 3Type: Bug

Description

Correcting a work's author (e.g. https://openlibrary.org/works/OL3531880W/Living_with_Leviathan?b=4&a=3&_compare=Compare&m=diff ) also corrects the Alt-text for the work cover, (e.g. to alt="Cover of: Living with Leviathan by David Brian Smith" ) but fails to correct the Alt-text for the editions below it, instead leaving it untouched (e.g. as alt="Cover of: Living with Leviathan by David Buchanan Smith" ). Might this be why the edition is still found on searches for the old author spelling?

view-source:https://openlibrary.org/books/OL17631357M/Living_with_Leviathan shows the error at lines 349, 357, 371

Proposed fix: Ensure the edition alt-text author name uses the same source data as the rest of the edition interface, which takes the author attached to the work(if it exists)

Contributor guide

Tech stack
python
Domain
backendaccessibility
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of PythonFamiliarity with OpenLibrary's data model (works vs editions)
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Focus on the template or view that generates the HTML for edition book covers. Look in the OpenLibrary codebase for where 'alt' attribute of cover images is set, likely in a Python template file (e.g., .html or .pt). The issue notes that the alt text for editions does not update when the work's author is corrected, while the work cover does. Compare how the work cover gets its author data versus the edition cover. Ensure that the edition alt text uses the same author source as the rest of the edition interface, which should be the work's author if available.