internetarchive/openlibrary

Graceful Error should occur when user w/ MAX LOANS attempts borrow

Open

#439 opened on Mar 10, 2017

View on GitHubContributor guide
 (18 comments) (1 reaction) (1 assignee)Python (1,957 forks)batch import
Affects: UILead: @mekarpelesModule: Borrowing / LendingNeeds: ReviewPriority: 4Type: Bughacktoberfest

Repository metrics

Stars
 (6,608 stars)
PR merge metrics
 (Avg merge 6d 2h) (126 merged PRs in 30d)

Description

When a user has 5 books borrowed, no borrow button should appear on the works / editions pages. Discovered by Benjamin (in QA)

Contributor guide

Research direction
Trace the borrow button rendering logic to find where user loan count is checked. Ensure that when loan count reaches 5, the button is hidden or replaced with a message. Check the template and controller handling the borrow action.
Tech stack
python
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75