internetarchive/openlibrary

Use --no-install-recommends in dockerfiles

Open

#2,656 opened on Nov 19, 2019

View on GitHub
 (6 comments) (0 reactions) (1 assignee)Python (4,626 stars) (1,172 forks)batch import
Good First IssueLead: @cdriniModule: DockerNeeds: ResponsePriority: 3Theme: DevelopmentType: Refactor/Clean-up

Description

Anywhere we use apt-get install in our Dockerfiles, we should also add --no-install-recommends. According to https://ubuntu.com/blog/we-reduced-our-docker-images-by-60-with-no-install-recommends this creates smaller images which build faster. Note:

It is important to keep in mind that doing this could result in some missing libraries in your projects which you may have to add back explicitly, but this will ultimately give you more control in the dependencies in your project.

Contributor guide

Tech stack
dockershell
Domain
infrastructurebuild system
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of DockerFamiliarity with apt get
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue is assigned to someone and has no linked PRs. Review all Dockerfiles in the repository (e.g., Dockerfile, docker compose files) for apt get install commands. Add the no install recommends flag to each occurrence. Be aware that removing recommended packages may cause missing dependencies; test the resulting Docker images to ensure functionality. The maintainer's note advises that missing libraries may need to be added back explicitly.