intellij-rust/intellij-rust

Unused parentheses are not highlighted for assigned value

Open

#9,220 opened on Aug 21, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Kotlin (376 forks)batch import
help wantedimprovementsubsystem::highlighting

Repository metrics

Stars
 (4,526 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Environment

  • IntelliJ Rust plugin version: 0.4.177.4822-222-nightly
  • Rust toolchain version: 1.63.0 (4b91a6ea7 2022-08-08) x86_64-apple-darwin
  • IDE name and version: IntelliJ IDEA 2022.2 Ultimate Edition (IU-222.3345.118)
  • Operating system: macOS 12.3.1
  • Macro expansion engine: new
  • Name resolution engine: new
  • Additional experimental features: org.rust.cargo.features.settings.gutter, org.rust.cargo.emulate.terminal, org.rust.cargo.evaluate.build.scripts, org.rust.macros.proc

Problem description

The plugin detects unused parentheses in some expressions. But if it's an expression in an assigned statement, the plugin shows nothing. At the same time, rustc show the warning "warning: unnecessary parentheses around assigned value"

Related to #9197

Steps to reproduce

fn main() {
    let _range = (1..12);
    let _a = (1 + 1);
}

Contributor guide

Research direction
Locate the unused parentheses inspection in the Rust plugin code (likely in an inspection file under src/main/kotlin/org/rust/lang/core/inspections/). Identify where it checks for unnecessary parentheses and extend the logic to handle assignments (let x = (expr);). Ensure the inspection triggers on assigned values as well, similar to how rustc warns.
Tech stack
rustkotlin
Domain
devtools
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitKotlinRust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60