[Bug]: Broken links

Open
#3 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
65/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
html, javascript
Domain
frontend, web-dev

Research direction

Start at https://intel.github.io/SDM/sdm.html?instr=ADCX, inspect the underlined “scalar” navigation and check the browser console for the reported errors. Trace that link’s frontend implementation, then verify that it reaches the scalar-instructions page and supports normal browser navigation in Firefox, Safari, and Chrome.

Written by the indexing model from the issue text.

Description

UI issue
Description

The bizarre choice to use JavaScript onclick handlers for linking between documents rather than standard HTML links breaks browsers' normal navigation even in best cases. For example, I can no longer open links in a new tab to compare similar instructions. This is a usability failure.

Worse, the implementation is buggy and some links do not work at all. This bug describes one such example, but there are probably many more.

Steps to Reproduce
  1. Visit https://intel.github.io/SDM/sdm.html?instr=ADCX
  2. Click on the underlined "scalar" which looks like a link.
  3. Nothing happens. (If I open the JavaScript console, I see various errors.)
Expected Behavior

I expected to be taken to a page about scalar instructions.

Environment

Firefox 140.15.0esr for macOS.

I also tested in Safari and Chrome and the same thing happens.

Additional Context

Please tell your frontend developer(s) that <A HREF="target url"> is a thing. The approach they've taken is brittle.

Dominant language
HTML
Stars
31
Forks
4
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from intel/SDM

All issues in intel/SDM

Similar issues

More Web Dev issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.