inkle/ink

Crash in VariableStateDidChangeEvent

Open

#113 opened on Jun 23, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C# (3,743 stars) (466 forks)batch import
help wanted

Description

If the user calls _inkStory.RemoveVariableObserver(...) followed by _InkStory.ResetState(...) the app crashes inside VariableStateDidChangeEvent.

I am using Unity 5.3.4.f1 Personal.

The methods were called in a C# script.

Contributor guide

Tech stack
csharp
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
C# programmingUnity basicsink scripting language
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the VariableStateDidChangeEvent handler in the ink runtime. Look at how RemoveVariableObserver and ResetState interact, especially the order of operations. Check the source files related to variable state and event delegation. The crash likely occurs due to a null pointer or removed observer being called after state reset. A fix might involve resetting or clearing observers during ResetState.