influxdata/telegraf

Add retry feature for http secret-store plugin

Open

#15,846 opened on Sep 5, 2024

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Go (9,892 stars) (4,161 forks)batch import
feature requesthelp wantedsize/l

Description

Use Case

Use the scretstore http plugin to retrieve connection information from postgresql output. However, in the current situation, if the secretstore http plugin fails to retrieve the API value, the service does not start because @ variable substitution is not performed.

Expected behavior

  • API call setup : Use @ variable
  • API connection failure : Retry

Actual behavior

  • API call setup : Use @ variable
  • API connection failure : service down ( The reason is that the @ variable does not have a value and attempts to connect in an unsubstituted state.)

Additional info

[[secretstores.http]]
  id = "meta"
  url = "http://localhost/meta"
  timeout = "5s"
  
[[outputs.postgresql]]
  connection = "host=@{meta:host} port=@{meta:port} user=@{meta:user} password=@{meta:password} dbname=@{meta:database} sslmode=disable"

Contributor guide

Tech stack
go
Domain
backendinfrastructure
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with GoBasic understanding of HTTP clients
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the HTTP secret store plugin implementation in Telegraf, likely under `plugins/secretstores/http/`. Understand how the plugin currently handles API responses and errors. Look for existing retry utilities in the codebase (e.g., in `internal/`). The goal is to add retry logic with configurable attempts and backoff after an HTTP failure. Consider reviewing similar retry patterns in other plugins (e.g., output plugins) for consistency.