influxdata/telegraf

Proxmox Input Plugin exposes useless fields

Open

#10,617 opened on Feb 9, 2022

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Go (9,892 stars) (4,161 forks)batch import
feature requesthelp wantedsize/m

Description

Feature Request

The Proxmox Input Plugin exposes, among others, the following fields:

  • disk_used
  • disk_total
  • disk_free
  • disk_used_percentage

It exposes these for every VM running on Proxmox.

The issue is, Proxmox has no idea about disk usage of each VM, because without visibility into the running VM, Proxmox just see's the VM's disk file.

Proposal:

Report on the Proxmox host storage pool disk stats instead. Proxmox exposes these easily with the pvesm status command.

Current behavior:

The current behaviour gives completely meaningless values for the above metrics. Mostly it just reports back the size of the VM disk image (e.g. raw file size).

Desired behavior:

Ditch the above metrics and replace with Proxmox storage pool stats, e.g. these:

image

image

Use case:

I'd like to monitor the storage pool space in Proxmox! This goes for the entire plugin actually, I'd like to monitor Proxmox host stats not just individual VM's running in Proxmox.

Contributor guide

Tech stack
go
Domain
backendinfrastructureobservability
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go programmingTelegraf plugin developmentProxmox API basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the existing Proxmox input plugin code in plugins/inputs/proxmox/ to understand current metrics collection. Look at the 'pvesm status' command output format and compare with desired storage pool stats. Implement changes to replace VM disk metrics with storage pool metrics, ensuring backward compatibility or a new metric set. Check any existing comments in the issue for additional context.